[tim-janik/beast] Track primitive properties ported to C++ (#109)

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[tim-janik/beast] Track primitive properties ported to C++ (#109)

Gnome - Beast mailing list

I've ported all Track properties to C++ that do not contain object references. Two things are worth mentioning.

  1. Const MIDI_MAX_CHANNEL - I declared this as constant, but maybe the definition must be moved elsewhere. It seems to be required in bsebasics.idl, too (there is a // FIXME: MAX_MIDI_CHANNEL in the MidiChannelEvent definition)
  2. I didn't touch "signal::property-notify::n-voices" and similar signal code in bsttrackview.cc, I'm not sure what the C++ property equivalent would be

You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/109

Commit Summary

  • BSE: Track::muted: port property to C++
  • BEAST-GTK: bsttrackview: use muted C++ property
  • BSE: Track::midi_channel: port property to C++
  • BEAST-GTK: bsttrackview: use midi_channel C++ property
  • BSE: Track::n_voices: port property to C++
  • BEAST-GTK: bsttrackview: use n_voices C++ property

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XUXZGOWXOLPMOHJ6Q3QBXATPA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HB5AJSA", "url": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XUXZGOWXOLPMOHJ6Q3QBXATPA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HB5AJSA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Track primitive properties ported to C++ (#109)

Gnome - Beast mailing list

@swesterfeld pushed 1 commit.

  • 4b2dc59 BEAST-GTK: bsttrackview: port track view notifications for C++ properties


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/109/files/9d1ea0739c5a4148ec70a9451e21b25e93386af1..4b2dc5948b90eacb4d81cbdfdea2531d1d963434?email_source=notifications\u0026email_token=AIVS7XREPLB6Y7MN4AWONTDQDBAFXA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGMYDCOBUGI3DQOCQOVZWQIZTHA4TCMBXHAYDQMY", "url": "https://github.com/tim-janik/beast/pull/109/files/9d1ea0739c5a4148ec70a9451e21b25e93386af1..4b2dc5948b90eacb4d81cbdfdea2531d1d963434?email_source=notifications\u0026email_token=AIVS7XREPLB6Y7MN4AWONTDQDBAFXA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGMYDCOBUGI3DQOCQOVZWQIZTHA4TCMBXHAYDQMY", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Track primitive properties ported to C++ (#109)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

I didn't touch "signal::property-notify::n-voices" and similar signal code

Update: I ported this to C++ now using track.on("notify:n_voices",...) for the new properties.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XVSEYBKQBGX4W4BMY3QDBATPA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SFCAY#issuecomment-518279427", "url": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XVSEYBKQBGX4W4BMY3QDBATPA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SFCAY#issuecomment-518279427", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Track primitive properties ported to C++ (#109)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

@swesterfeld pushed 1 commit.

  • a426a3a BSE: Song: fix access to C++ Track::muted property


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/109/files/4b2dc5948b90eacb4d81cbdfdea2531d1d963434..a426a3a50c2c7834071c630387f795b8a506ce76?email_source=notifications\u0026email_token=AIVS7XVDGGJ75245B567KG3QDKPF3A5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGMYDCOBUGI3DQOCQOVZWQIZTHA4TQNRVGI3TANI", "url": "https://github.com/tim-janik/beast/pull/109/files/4b2dc5948b90eacb4d81cbdfdea2531d1d963434..a426a3a50c2c7834071c630387f795b8a506ce76?email_source=notifications\u0026email_token=AIVS7XVDGGJ75245B567KG3QDKPF3A5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFXNIHK3DMKJSXC5LFON2FA5LTNBHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZF5KB2WY3BDGMYDCOBUGI3DQOCQOVZWQIZTHA4TQNRVGI3TANI", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Track primitive properties ported to C++ (#109)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

@tim-janik commented on this pull request.


In beast-gtk/bsttrackview.hh:

> @@ -20,11 +20,13 @@ typedef	struct	_BstTrackView	   BstTrackView;
 typedef	struct	_BstTrackViewClass BstTrackViewClass;
 struct _BstTrackView
 {
-  BstItemView	          parent_object;
-  Bse::SongS              song;
-  BstTrackRoll	         *troll;
-  BstTrackRollController *tctrl;
-  GtkWidget		 *repeat_toggle;
+  BstItemView                     parent_object;
+  Bse::SongS                      song;
+  std::map<SfiProxy, Bse::TrackS> track_map;

Note, I'm perfectly happy with adding type aliases for complex types, so you don't need to reformat all members. E.g.

using TrackMap = std::map<SfiProxy, Bse::TrackS>;
// other members...
TrackMap    track_map;


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XXF6OOZ4RJOMXK2UCLQDP4IHA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCA67HZQ#pullrequestreview-272495590", "url": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XXF6OOZ4RJOMXK2UCLQDP4IHA5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCA67HZQ#pullrequestreview-272495590", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Track primitive properties ported to C++ (#109)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

Closed #109 via 223623e.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XWI7H6F6ZTCZX7RV53QDQH53A5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS6LCTSI#event-2543200713", "url": "https://github.com/tim-janik/beast/pull/109?email_source=notifications\u0026email_token=AIVS7XWI7H6F6ZTCZX7RV53QDQH53A5CNFSM4IHM3OR2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS6LCTSI#event-2543200713", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast