[tim-janik/beast] Port Song::loop_left property (#65)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[tim-janik/beast] Port Song::loop_left property (#65)

Gnome - Beast mailing list

One more property C++ified.


You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/65

Commit Summary

  • BSE: Song::loop_left: port property to C++
  • BEAST-GTK: use C++ property Song::loop_left

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Port Song::loop_left property (#65)"}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/65"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/65", "url": "https://github.com/tim-janik/beast/pull/65", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Port Song::loop_left property (#65)", "sections": [ { "text": "", "activityTitle": "**Stefan Westerfeld**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@swesterfeld", "facts": [ ] }, { "title": "Commit Summary", "facts": [ { "name": "dc679a2", "value": "BSE: Song::loop_left: port property to C++" }, { "name": "b627d8f", "value": "BEAST-GTK: use C++ property Song::loop_left" } ] }, { "title": "File Changes", "facts": [ { "name": "Modified", "value": "[beast-gtk/bsttrackrollctrl.cc](https://github.com/tim-janik/beast/pull/65/files#diff-0) (3 changes)" }, { "name": "Modified", "value": "[beast-gtk/bsttrackview.cc](https://github.com/tim-janik/beast/pull/65/files#diff-1) (7 changes)" }, { "name": "Modified", "value": "[bse/bseapi.idl](https://github.com/tim-janik/beast/pull/65/files#diff-2) (5 changes)" }, { "name": "Modified", "value": "[bse/bsesong.cc](https://github.com/tim-janik/beast/pull/65/files#diff-3) (56 changes)" }, { "name": "Modified", "value": "[bse/bsesong.hh](https://github.com/tim-janik/beast/pull/65/files#diff-4) (2 changes)" } ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"issueId\": 65,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"pullRequestId\": 65\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65.patch" } ], "@type": "OpenUri", "name": "View patch" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65.diff" } ], "@type": "OpenUri", "name": "View diff" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 371634347\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Port Song::loop_left property (#65)

Gnome - Beast mailing list

@swesterfeld pushed 1 commit.

  • 7bab5fe BSE: bseapi: use constants SKIP_DEFAULT / SKIP_UNDO for ported properties


You are receiving this because you are subscribed to this thread.
View it on GitHub or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"PERSON","message":"@swesterfeld pushed 1 commit in #65"}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/65/files/14828cc823c18a9cb1fcbd320ca1988a9d65a62c..7bab5fe02ff2b5414db1a0d77e18fd0e8a471078"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/65/files/14828cc823c18a9cb1fcbd320ca1988a9d65a62c..7bab5fe02ff2b5414db1a0d77e18fd0e8a471078", "url": "https://github.com/tim-janik/beast/pull/65/files/14828cc823c18a9cb1fcbd320ca1988a9d65a62c..7bab5fe02ff2b5414db1a0d77e18fd0e8a471078", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "@swesterfeld pushed 1 commit in #65", "sections": [ { "text": "1 new commit pushed to tim-janik/beast #65:", "activityTitle": "**Stefan Westerfeld**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@swesterfeld", "facts": [ { "name": "7bab5fe", "value": "BSE: bseapi: use constants SKIP_DEFAULT / SKIP_UNDO for ported properties" } ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65/files/14828cc823c18a9cb1fcbd320ca1988a9d65a62c..7bab5fe02ff2b5414db1a0d77e18fd0e8a471078" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 371634347\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Port Song::loop_left property (#65)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

After the constant parsing was fixed in master, I rebased and updated this branch to now use SKIP_DEFAULT/SKIP_UNDO.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"PERSON","message":"@swesterfeld in #65: After the constant parsing was fixed in master, I rebased and updated this branch to now use SKIP_DEFAULT/SKIP_UNDO."}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/65#issuecomment-415670423"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/65#issuecomment-415670423", "url": "https://github.com/tim-janik/beast/pull/65#issuecomment-415670423", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [tim-janik/beast] Port Song::loop_left property (#65)", "sections": [ { "text": "", "activityTitle": "**Stefan Westerfeld**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@swesterfeld", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"issueId\": 65,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"pullRequestId\": 65\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65#issuecomment-415670423" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 371634347\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Port Song::loop_left property (#65)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

Thanks for the PR, a couple comments:

  •  SfiInt lleft = self->song.loop_left();
    

Use just int, float, etc in new code, instead of gint or SfiInt.

  • BseSong self = const_cast<SongImpl> (this)->as<BseSong >();
    This should be "as<BseSong
    >", without the extra space.
  •  bool loop_enabled = self->loop_enabled_SL;
    

You're saving an old value here for comparing later. There's no need to keep this a variable, i.e. please make that const in similar code in the future:
+ const bool loop_enabled = self->loop_enabled_SL;


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tim-janik in #65: Thanks for the PR, a couple comments:\r\n\u003e + SfiInt lleft = self-\u003esong.loop_left();\r\nUse just int, float, etc in new code, instead of gint or SfiInt.\r\n\r\n\u003e + BseSong *self = const_cast\u003cSongImpl*\u003e (this)-\u003eas\u003cBseSong *\u003e();\r\nThis should be \"as\u003cBseSong*\u003e\", without the extra space.\r\n\r\n\u003e + bool loop_enabled = self-\u003eloop_enabled_SL;\r\nYou're saving an old value here for comparing later. There's no need to keep this a variable, i.e. please make that const in similar code in the future:\r\n\t+ const bool loop_enabled = self-\u003eloop_enabled_SL;"}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/65#issuecomment-416056536"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/65#issuecomment-416056536", "url": "https://github.com/tim-janik/beast/pull/65#issuecomment-416056536", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [tim-janik/beast] Port Song::loop_left property (#65)", "sections": [ { "text": "", "activityTitle": "**Tim Janik**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@tim-janik", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"issueId\": 65,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"pullRequestId\": 65\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65#issuecomment-416056536" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 371634347\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Port Song::loop_left property (#65)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

Closed #65 via 626efb2.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #65 via 626efb2af3e78490c23278c435f6c159e7aeed1b."}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/65#event-1809442347"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/65#event-1809442347", "url": "https://github.com/tim-janik/beast/pull/65#event-1809442347", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [tim-janik/beast] Port Song::loop_left property (#65)", "sections": [ { "text": "", "activityTitle": "**Tim Janik**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@tim-janik", "facts": [ ] } ], "potentialAction": [ { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/65#event-1809442347" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 371634347\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast