[tim-janik/beast] Item properties ported to C++ (#115)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[tim-janik/beast] Item properties ported to C++ (#115)

Gnome - Beast mailing list

Actually this is just one property: seqid

Since no more properties remain, I wonder if I should add a commit which removes the setter/getter (in this case bse_item_set|get_property_internal).


You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/115

Commit Summary

  • BSE: Item::seqid: port property to C++
  • BEAST-GTK: bsttreestores: use seqid C++ property

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/115?email_source=notifications\u0026email_token=AIVS7XUEFQ72KU3DZWL5QH3QDPKSHA5CNFSM4IKHXC72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HECVC6Q", "url": "https://github.com/tim-janik/beast/pull/115?email_source=notifications\u0026email_token=AIVS7XUEFQ72KU3DZWL5QH3QDPKSHA5CNFSM4IKHXC72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HECVC6Q", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Item properties ported to C++ (#115)

Gnome - Beast mailing list

Actually this is just one property: seqid

Since no more properties remain, I wonder if I should add a commit which removes the setter/getter (in this case bse_item_set|get_property_internal).

Haven't reviewed yet, but yes, that sounds like a good plan.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/115?email_source=notifications\u0026email_token=AIVS7XVN73PUW7UA3SEX3BTQDQI3NA5CNFSM4IKHXC72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33QADA#issuecomment-519503884", "url": "https://github.com/tim-janik/beast/pull/115?email_source=notifications\u0026email_token=AIVS7XVN73PUW7UA3SEX3BTQDQI3NA5CNFSM4IKHXC72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33QADA#issuecomment-519503884", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Item properties ported to C++ (#115)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

Closed #115 via a48588c.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/115?email_source=notifications\u0026email_token=AIVS7XRCE6QCJZZGVNDAFMTQDVLBVA5CNFSM4IKHXC72YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS7CG76I#event-2546233337", "url": "https://github.com/tim-janik/beast/pull/115?email_source=notifications\u0026email_token=AIVS7XRCE6QCJZZGVNDAFMTQDVLBVA5CNFSM4IKHXC72YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS7CG76I#event-2546233337", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast