[tim-janik/beast] Fluidsynth2 (#101)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[tim-janik/beast] Fluidsynth2 (#101)

Gnome - Beast mailing list

This updates the fluidsynth code to fluidsynth >= 2.0.0. This is not backward compatible, BEAST will not build against fluidsynth 1 any longer. The soundfont audio test reference file had to be updated due to a bugfix in fluidsynth 1 related to voice panning.


You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/101

Commit Summary

  • BSE: Makefile.mk: use correct compiler flags for building libbse
  • BSE: SF2: port soundfont support to fluidsynth2 API
  • config-checks.mk: require fluidsynth >= 2.0.0
  • BSE: SF2: adapt fluidsynth settings to fluidsynth 2 constraints
  • TESTS: audio: adapt soundfont test reference file to fluidsynth2

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fluidsynth2 (#101)"}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/101"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/101", "url": "https://github.com/tim-janik/beast/pull/101", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Fluidsynth2 (#101)

Gnome - Beast mailing list

One remark about us using the deprecated fluid_nwrite_float() function: if I use the non-deprecated version, our soundfont audio unit test fails. And things start sounding somewhat crappy. Turns out that the new replacement function is buggy, and we trigger this. I submitted a fix to upstream.

FluidSynth/fluidsynth#527

But since it will take time until this propagates into official fluidsynth releases I recommend staying with the old deprecated API for some time.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"PERSON","message":"@swesterfeld in #101: One remark about us using the deprecated fluid_nwrite_float() function: if I use the non-deprecated version, our soundfont audio unit test fails. And things start sounding somewhat crappy. Turns out that the new replacement function is buggy, and we trigger this. I submitted a fix to upstream.\r\n\r\nhttps://github.com/FluidSynth/fluidsynth/pull/527\r\n\r\nBut since it will take time until this propagates into official fluidsynth releases I recommend staying with the old deprecated API for some time."}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/101#issuecomment-482972028"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/101#issuecomment-482972028", "url": "https://github.com/tim-janik/beast/pull/101#issuecomment-482972028", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Fluidsynth2 (#101)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

Closed #101 via 4c65148.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #101 via 4c65148cf152572cd0e7a8e012cd71f4216cda6b."}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/101#event-2276533784"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/101#event-2276533784", "url": "https://github.com/tim-janik/beast/pull/101#event-2276533784", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast