[tim-janik/beast] BSE: randomhash.hh: fix compilation on g++ 7.4.0 (#120)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[tim-janik/beast] BSE: randomhash.hh: fix compilation on g++ 7.4.0 (#120)

Gnome - Beast mailing list

std::string in C++17 cannot be used at compile time, so constexpr is not possible


You can view, comment on, or merge this pull request online at:

  https://github.com/tim-janik/beast/pull/120

Commit Summary

  • BSE: randomhash.hh: fix compilation on g++ 7.4.0

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/120?email_source=notifications\u0026email_token=AIVS7XQ7YVG2U57IPWCUOTTQG3DMFA5CNFSM4IRQBKA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIAHQQA", "url": "https://github.com/tim-janik/beast/pull/120?email_source=notifications\u0026email_token=AIVS7XQ7YVG2U57IPWCUOTTQG3DMFA5CNFSM4IRQBKA2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIAHQQA", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] BSE: randomhash.hh: fix compilation on g++ 7.4.0 (#120)

Gnome - Beast mailing list

fnv1a_consthash64() is named consthash because it proivdes a compile-time hash function, removing the constexpr means it cannot be used at compile time. It's a pitty that g++ doesn't handle this as well as clang, I'm removing the entire function for now.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/120?email_source=notifications\u0026email_token=AIVS7XQ5A5XIS6OXR5I7KVDQHUWTJA5CNFSM4IRQBKA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WDQLA#issuecomment-527185964", "url": "https://github.com/tim-janik/beast/pull/120?email_source=notifications\u0026email_token=AIVS7XQ5A5XIS6OXR5I7KVDQHUWTJA5CNFSM4IRQBKA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WDQLA#issuecomment-527185964", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] BSE: randomhash.hh: fix compilation on g++ 7.4.0 (#120)

Gnome - Beast mailing list
In reply to this post by Gnome - Beast mailing list

Closed #120 via bdbbed4.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/120?email_source=notifications\u0026email_token=AIVS7XSEKR27AZCIXDUJKB3QHUYMDA5CNFSM4IRQBKA2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTMHRGFA#event-2601456404", "url": "https://github.com/tim-janik/beast/pull/120?email_source=notifications\u0026email_token=AIVS7XSEKR27AZCIXDUJKB3QHUYMDA5CNFSM4IRQBKA2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTMHRGFA#event-2601456404", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast