Unknown symbol in 'gio/gresource.c'

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Unknown symbol in 'gio/gresource.c'

John Emmas
I just hit a problem when building from git master with MSVC (32-bit
build).  It's in 'gio/gresource.c' at line 254 in the function
'enumerate_overlay_dir()':-

       if (g_stat (fullname, &buf) == 0 && S_ISDIR (buf.st_mode))

'S_ISDIR' is coming up as an unknown symbol.  In other places where we
use S_ISDIR we usually have something like this near the top of the file:-

       #ifdef G_OS_WIN32
       #include <io.h>
       #ifndef S_ISDIR
       #define S_ISDIR(m) (((m) & _S_IFMT) == _S_IFDIR)
       #endif
       #endif

and if I add that near the top of 'gio/gresource.c' it fixes the
problem.  Just passing it upstream.  Regards,

John
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
LRN
Reply | Threaded
Open this post in threaded view
|

Re: Unknown symbol in 'gio/gresource.c'

LRN
On 02.05.2016 14:36, John Emmas wrote:
> I just hit a problem when building from git master with MSVC (32-bit
> build).
>
> 'S_ISDIR' is coming up as an unknown symbol.

fanc, care to comment?


--
O< ascii ribbon - stop html email! - www.asciiribbon.org


_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Unknown symbol in 'gio/gresource.c'

Fan, Chun-wei

Hi,

 

To fix this, we could just use g_file_test (fullname, G_FILE_TEST_IS_DIR) in place of the whole check that is there.

 

With blessings, and cheers!

 

Windows 10 手機傳送

 

寄件者: [hidden email]
傳送時間: 201652 下午 08:22
收件者: [hidden email]
副本: [hidden email]
主旨: Re: Unknown symbol in 'gio/gresource.c'

 

On 02.05.2016 14:36, John Emmas wrote:

> I just hit a problem when building from git master with MSVC (32-bit

> build).

>

> 'S_ISDIR' is coming up as an unknown symbol.

 

fanc, care to comment?

 

 

--

O< ascii ribbon - stop html email! - www.asciiribbon.org

 

 


_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
LRN
Reply | Threaded
Open this post in threaded view
|

Re: Unknown symbol in 'gio/gresource.c'

LRN
On 04.05.2016 13:25, Fan, Chun-wei wrote:

> On 2016年5月2日 下午08:22, LRN wrote:
>> On 02.05.2016 14:36, John Emmas wrote:
>>> I just hit a problem when building from git master with MSVC (32-bit
>>> build).
>>>
>>> 'S_ISDIR' is coming up as an unknown symbol.
>>
>> fanc, care to comment?
>
> To fix this, we could just use g_file_test (fullname, G_FILE_TEST_IS_DIR)
> in place of the whole check that is there.
Okay, g_file_test() is good.
Who will make a patch and bugzill it?


--
O< ascii ribbon - stop html email! - www.asciiribbon.org


_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list

signature.asc (484 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Unknown symbol in 'gio/gresource.c'

Fan, Chun-wei
In reply to this post by John Emmas
Hi John/LRN,

I opened a bug to fix the issue:
https://bugzilla.gnome.org/show_bug.cgi?id=765991

With blessings, and cheers!
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Reply | Threaded
Open this post in threaded view
|

Re: Unknown symbol in 'gio/gresource.c'

John Emmas
On 04/05/2016 16:05, [hidden email] wrote:
> Hi John/LRN,
>
> I opened a bug to fix the issue:
> https://bugzilla.gnome.org/show_bug.cgi?id=765991
>

That's great news.  Thanks.

John
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Reply | Threaded
Open this post in threaded view
|

Re: Unknown symbol in 'gio/gresource.c'

Fan, Chun-wei
Hi John,

The patch went upstream, so you should be able to build normally after
you sync.

With blessings!
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Reply | Threaded
Open this post in threaded view
|

Re: Unknown symbol in 'gio/gresource.c'

John Emmas
On 04/05/2016 16:54, [hidden email] wrote:
> Hi John,
>
> The patch went upstream, so you should be able to build normally after
> you sync.
>
> With blessings!
>

Yes, that's all building again now.  Thanks.
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list