Soundfont updates

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Soundfont updates

Stefan Westerfeld
   Hi!

After our last discussion, I've updated the wip/soundfont branch in stwbeast
repo again. Summary

  * GList changed to std::vector
  * all data members moved to C++ SoundFont*Impl classes
  * make check fixed (use search path to resolve relative paths)

I initially had problems with the order of the destruction, see comment in
commit 9f477e70e1d7b7b90d8b3bb31d5bded75ddf8b09, as the container
release_children runs after the C++ implementation object was destroyed, and
therefore can't access the state.

What I did to resolve the problem was to move bits and pieces from
*_release_children, *_dispose and *_finalize to the C++ implementation
destructor, so these functions don't need to access the state.

Anything else missing for merging SF2 support?

   Cu... Stefan
--
Stefan Westerfeld, http://space.twc.de/~stefan
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: Soundfont updates

Tim Janik-6
On 13.02.2017 18:11, Stefan Westerfeld wrote:
>    Hi!
>
> After our last discussion, I've updated the wip/soundfont branch in stwbeast
> repo again.

Great.

I'm getting a number of annoying warnings during testing with your branch merged
into master and ultimately an error:

make[3]: Entering directory '/opt/src/beast/tests/audio'
make[3]: Nothing to be done for 'all'.
make[3]: Nothing to be done for 'all'.
  WAVCHECK soundfont-test
fluidsynth: warning: Failed to pin the sample data to RAM; swapping is possible.
fluidsynth: warning: No preset found on channel 0 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 1 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 2 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 3 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 4 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 5 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 6 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 7 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 8 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 9 [bank=128 prog=0]
fluidsynth: warning: No preset found on channel 10 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 11 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 12 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 13 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 14 [bank=0 prog=0]
fluidsynth: warning: No preset found on channel 15 [bank=0 prog=0]
fluidsynth: warning: Failed to pin the sample data to RAM; swapping is possible.
  WAVCHECK sum-diff-test
sum-diff-test.tmp:9: error: unexpected identifier 'inf', expected number (float)
Makefile:790: recipe for target 'sum-diff-test' failed
make[3]: *** [sum-diff-test] Error 1


Will apply the other fixes you had pending next and see if that remdies something.


--
Yours sincerely,
Tim Janik

https://testbit.eu/timj/
Free software author.
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast
Reply | Threaded
Open this post in threaded view
|

Re: Soundfont updates

Stefan Westerfeld
   Hi!

On Wed, Mar 08, 2017 at 10:52:23PM +0100, Tim Janik wrote:

> On 13.02.2017 18:11, Stefan Westerfeld wrote:
> > After our last discussion, I've updated the wip/soundfont branch in stwbeast
> > repo again.
>
> Great.
>
> I'm getting a number of annoying warnings during testing with your branch merged
> into master and ultimately an error:
>
> make[3]: Entering directory '/opt/src/beast/tests/audio'
> make[3]: Nothing to be done for 'all'.
> make[3]: Nothing to be done for 'all'.
>   WAVCHECK soundfont-test
> fluidsynth: warning: Failed to pin the sample data to RAM; swapping is possible.
> fluidsynth: warning: No preset found on channel 0 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 1 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 2 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 3 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 4 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 5 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 6 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 7 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 8 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 9 [bank=128 prog=0]
> fluidsynth: warning: No preset found on channel 10 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 11 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 12 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 13 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 14 [bank=0 prog=0]
> fluidsynth: warning: No preset found on channel 15 [bank=0 prog=0]
> fluidsynth: warning: Failed to pin the sample data to RAM; swapping is possible.
>   WAVCHECK sum-diff-test
> sum-diff-test.tmp:9: error: unexpected identifier 'inf', expected number (float)
> Makefile:790: recipe for target 'sum-diff-test' failed
> make[3]: *** [sum-diff-test] Error 1

I committed a fix for the warnings into the wip/soundfont branch.

   Cu... Stefan
--
Stefan Westerfeld, http://space.twc.de/~stefan
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast