Re: [tim-janik/beast] Translated SNet module menu duplication (#20)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] Translated SNet module menu duplication (#20)

Gnome - Beast mailing list

I managed to reproduce this here, using:

LANGUAGE= LANG=de_DE.UTF-8 beast

The duplicate entries are due to a mixture of translated labels used in the menu paths. I.e. in one place we create a menu item "_Audio Quellen" from "/_Audio Sources/", in another place we refer to that menu entry as "/Audio Sources/XtalStrings". Some module names are translated, others not, and then the menu logic can not always properly join items, becuase the paths aren't translated piecewise.

Basically, there's no good way to fix this, other than redoing the path specifications during our next module migration. We need to split up the segments, so joining, translation and accelerator creation can be properly segmented. E.g.:

-Info    category   = _("/Enhance/ArtsCompressor");
+Info    menu_category   = "Enhance";
+Info    module_title        = _("ArtsCompressor");

And maybe (just maybe), we shouldn't be translating the module names at all, since those are names after all. Or have a secondary title, to help beginners, e.g.:

-Info    category  = _("/Audio Sources/DavOrgan");
+Info    menu_category   = _("Audio Sources");    // DE: "Audio Quellen"
+Info    module_name     = "DavOrgan";
+Info    module_title        = _("synthetic organ");    // DE: "Synthetische Orgel";

Which becomes:

EN: → Audio Sources → DavOrgan (synthetic organ)
DE: → Audio Quellen → DavOrgan (Synthetische Orgel)

I'm happy to take patches towards implementing this. Short of someone else hacking on this, I'll probably address this at a later point when the plugin idl files need to be migrated.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tim-janik in #20: I managed to reproduce this here, using:\r\n\r\n LANGUAGE= LANG=de_DE.UTF-8 beast\r\n\r\nThe duplicate entries are due to a mixture of translated labels used in the menu paths. I.e. in one place we create a menu item \"_Audio Quellen\" from \"/_Audio Sources/\", in another place we refer to that menu entry as \"/Audio Sources/XtalStrings\". Some module names are translated, others not, and then the menu logic can not always properly join items, becuase the paths aren't translated piecewise.\r\n\r\nBasically, there's no good way to fix this, other than redoing the path specifications during our next module migration. We need to split up the segments, so joining, translation and accelerator creation can be properly segmented. E.g.:\r\n\r\n -Info category = _(\"/Enhance/ArtsCompressor\");\r\n +Info menu_category = \"Enhance\";\r\n +Info module_title = _(\"ArtsCompressor\");\r\n\r\nAnd *maybe* (just maybe), we shouldn't be translating the module names at all, since those are names after all. Or have a secondary title, to help beginners, e.g.:\r\n\r\n -Info category = _(\"/Audio Sources/DavOrgan\");\r\n +Info menu_category = _(\"Audio Sources\"); // DE: \"Audio Quellen\"\r\n +Info module_name = \"DavOrgan\";\r\n +Info module_title = _(\"synthetic organ\"); // DE: \"Synthetische Orgel\";\r\n\r\nWhich becomes:\r\n\r\n EN: → Audio Sources → DavOrgan (synthetic organ)\r\n DE: → Audio Quellen → DavOrgan (Synthetische Orgel)\r\n\r\nI'm happy to take patches towards implementing this. Short of someone else hacking on this, I'll probably address this at a later point when the plugin idl files need to be migrated."}],"action":{"name":"View Issue","url":"https://github.com/tim-janik/beast/issues/20#issuecomment-417517303"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/issues/20#issuecomment-417517303", "url": "https://github.com/tim-janik/beast/issues/20#issuecomment-417517303", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [tim-janik/beast] Translated SNet module menu duplication (#20)", "sections": [ { "text": "", "activityTitle": "**Tim Janik**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@tim-janik", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"issueId\": 20,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close issue", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"issueId\": 20\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/issues/20#issuecomment-417517303" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 260704954\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast