Re: [tim-janik/beast] BEAST: automatically create and connect new bus for new tracks (#16)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [tim-janik/beast] BEAST: automatically create and connect new bus for new tracks (#16)

Gnome - Beast mailing list

Ok, I rebased the branch (more like: manually fixed/recommitted what we need). As you say, it is possible to trigger an undo problem like this:

With your PR applied, the following sequence of actions triggers a warning for me:
start beast -> Project/New-Song -> Add-Track -> Delete-Mixer/Bus-1 -> Undo -> Undo
Yields:
WARNING: error during undo 'connect_bus' of item "BseBus::Master-1": Parent mismatch

However, I investigated the issue and it is not a problem created by the commits in this branch. I've created a new issue for this problem #79 and this shouldn't block merging this PR.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/tim-janik/beast","title":"tim-janik/beast","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/tim-janik/beast"}},"updates":{"snippets":[{"icon":"PERSON","message":"@swesterfeld in #16: Ok, I rebased the branch (more like: manually fixed/recommitted what we need). As you say, it is possible to trigger an undo problem like this:\r\n\r\n\u003e With your PR applied, the following sequence of actions triggers a warning for me:\r\n\u003e start beast -\u003e Project/New-Song -\u003e Add-Track -\u003e Delete-Mixer/Bus-1 -\u003e Undo -\u003e Undo\r\n\u003e Yields:\r\n\u003e WARNING: error during undo 'connect_bus' of item \"BseBus::Master-1\": Parent mismatch\r\n\r\nHowever, I investigated the issue and it is not a problem created by the commits in this branch. I've created a new issue for this problem https://github.com/tim-janik/beast/issues/79 and this shouldn't block merging this PR."}],"action":{"name":"View Pull Request","url":"https://github.com/tim-janik/beast/pull/16#issuecomment-419495341"}}}</script> <script type="application/ld+json">[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/tim-janik/beast/pull/16#issuecomment-419495341", "url": "https://github.com/tim-janik/beast/pull/16#issuecomment-419495341", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [tim-janik/beast] BEAST: automatically create and connect new bus for new tracks (#16)", "sections": [ { "text": "", "activityTitle": "**Stefan Westerfeld**", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@swesterfeld", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"issueId\": 16,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "name": "Close pull request", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"tim-janik/beast\",\n\"pullRequestId\": 16\n}" }, { "targets": [ { "os": "default", "uri": "https://github.com/tim-janik/beast/pull/16#issuecomment-419495341" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 237057009\n}" } ], "themeColor": "26292E" } ]</script>
_______________________________________________
beast mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/beast