Poppler binding bug / G::O::I

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
Hello,

A bug related to memory management was reported for the Poppler bindings I am maintaining:

https://rt.cpan.org/Public/Bug/Display.html?id=130280

The module uses Glib::Object::Introspection to generate the bindings, and I'm unsure if the fix for this bug should be in G::O::I or some sort of override in the Poppler module. Getting too deep into the glib/XS internals may be beyond me, and I'm hoping someone on this list might have suggestions on how to approach the issue.

Many thanks,
Jeremy
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Torsten Schoenfeld-2
On 26.08.19 18:43, Jeremy Volkening via gtk-perl-list wrote:
> A bug related to memory management was reported for the Poppler bindings I am maintaining:
>
> https://rt.cpan.org/Public/Bug/Display.html?id=130280
>
> The module uses Glib::Object::Introspection to generate the bindings, and I'm unsure if the fix for this bug should be in G::O::I or some sort of override in the Poppler module. Getting too deep into the glib/XS internals may be beyond me, and I'm hoping someone on this list might have suggestions on how to approach the issue.

Looks like a bug in Glib::Object::Introspection.  Can you try the change
I just committed?

https://gitlab.gnome.org/GNOME/perl-glib-object-introspection/commit/42cdec8f455bd855c3f4af056d82f6acd10ab36a

-Torsten
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
On Fri, Sep 13, 2019 at 12:20:11PM +0200, Torsten Schoenfeld wrote:
> > The module uses Glib::Object::Introspection to generate the bindings, and I'm unsure if the fix for this bug should be in G::O::I or some sort of override in the Poppler module. Getting too deep into the glib/XS internals may be beyond me, and I'm hoping someone on this list might have suggestions on how to approach the issue.
>
> Looks like a bug in Glib::Object::Introspection.  Can you try the change
> I just committed?
>
> https://gitlab.gnome.org/GNOME/perl-glib-object-introspection/commit/42cdec8f455bd855c3f4af056d82f6acd10ab36a

Thank you for looking into it. The user reports that the patch has indeed fixed the original issue -- however, it appears that the memory is now being freed too early. He has provided in-depth details in the CPAN bug report:

https://rt.cpan.org/Ticket/Display.html?id=130280

I also suggested that he open a new thread here to get in contact with you directly.

Thanks,
Jeremy
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Torsten Schoenfeld-2
On 16.09.19 17:44, Jeremy Volkening via gtk-perl-list wrote:
> Thank you for looking into it. The user reports that the patch has indeed fixed the original issue -- however, it appears that the memory is now being freed too early. He has provided in-depth details in the CPAN bug report:
>
> https://rt.cpan.org/Ticket/Display.html?id=130280

The issue is now tracked at
<https://gitlab.gnome.org/GNOME/perl-glib-object-introspection/issues/1>.

-Torsten
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
Le dim. 29 sept. 2019 à 19:25, Torsten Schoenfeld
<[hidden email]> a écrit :
> > Thank you for looking into it. The user reports that the patch has indeed fixed the original issue -- however, it appears that the memory is now being freed too early. He has provided in-depth details in the CPAN bug report:
> >
> > https://rt.cpan.org/Ticket/Display.html?id=130280
>
> The issue is now tracked at
> <https://gitlab.gnome.org/GNOME/perl-glib-object-introspection/issues/1>.

The commited fix results in:
*** Poppler::Document::new_from_data: passed too many parameters
(expected 3, got 4); ignoring excess at t/arrays.t line 204.
need an array ref to convert to GArray at t/arrays.t line 204.
t/arrays.t ....................
Dubious, test returned 255 (wstat 65280, 0xff00)
(...)
Test Summary Report
-------------------
t/arrays.t                  (Wstat: 65280 Tests: 72 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 88 tests but ran 72.
Files=18, Tests=389,  2 wallclock secs ( 0.09 usr  0.02 sys +  1.45
cusr  0.19 csys =  1.75 CPU)
Result: FAIL
Failed 1/18 test programs. 0/389 subtests failed.
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
Le lun. 7 oct. 2019 à 12:04, Thierry Vignaud
<[hidden email]> a écrit :

> > > Thank you for looking into it. The user reports that the patch has indeed fixed the original issue -- however, it appears that the memory is now being freed too early. He has provided in-depth details in the CPAN bug report:
> > >
> > > https://rt.cpan.org/Ticket/Display.html?id=130280
> >
> > The issue is now tracked at
> > <https://gitlab.gnome.org/GNOME/perl-glib-object-introspection/issues/1>.
>
> The commited fix results in:
> *** Poppler::Document::new_from_data: passed too many parameters
> (expected 3, got 4); ignoring excess at t/arrays.t line 204.
> need an array ref to convert to GArray at t/arrays.t line 204.
> t/arrays.t ....................
> Dubious, test returned 255 (wstat 65280, 0xff00)
> (...)
> Test Summary Report
> -------------------
> t/arrays.t                  (Wstat: 65280 Tests: 72 Failed: 0)
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 88 tests but ran 72.
> Files=18, Tests=389,  2 wallclock secs ( 0.09 usr  0.02 sys +  1.45
> cusr  0.19 csys =  1.75 CPU)
> Result: FAIL
> Failed 1/18 test programs. 0/389 subtests failed.

Using poppler-0.80.0
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
In reply to this post by Gtk+ - Perl mailing list
On Mon, Oct 7, 2019 at 3:04 AM Thierry Vignaud via gtk-perl-list
<[hidden email]> wrote:
> The commited fix results in:
> *** Poppler::Document::new_from_data: passed too many parameters
> (expected 3, got 4); ignoring excess at t/arrays.t line 204.
> need an array ref to convert to GArray at t/arrays.t line 204.

In addition to the above test error if you *do* have Poppler
installed, the value for skipping the new Poppler tests was set to
'1', as in "skip one test", and there's actually 16 Poppler tests that
need to be skipped if the Poppler library is not installed.  The
attached patch fixes the test count.  If nobody sees any problems with
it, I'll commit it, and wait for a decision and/or patch that takes
care of the above param count error before releasing G:O:I 0.048.

Thanks,

Brian

_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list

goi_1-poppler_skip_test_count.2019-10-07.patch (520 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
Le lun. 7 oct. 2019 à 16:54, Brian Manning <[hidden email]> a écrit :

> > The commited fix results in:
> > *** Poppler::Document::new_from_data: passed too many parameters
> > (expected 3, got 4); ignoring excess at t/arrays.t line 204.
> > need an array ref to convert to GArray at t/arrays.t line 204.
>
> In addition to the above test error if you *do* have Poppler
> installed, the value for skipping the new Poppler tests was set to
> '1', as in "skip one test", and there's actually 16 Poppler tests that
> need to be skipped if the Poppler library is not installed.  The
> attached patch fixes the test count.  If nobody sees any problems with
> it, I'll commit it, and wait for a decision and/or patch that takes
> care of the above param count error before releasing G:O:I 0.048.

err... the skip patch has already been committed at end of september AFAIK???
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list
Reply | Threaded
Open this post in threaded view
|

Re: Poppler binding bug / G::O::I

Gtk+ - Perl mailing list
On Mon, Oct 7, 2019 at 10:50 AM Thierry Vignaud
<[hidden email]> wrote:
> err... the skip patch has already been committed at end of september AFAIK???

My bad, I see it now.

Thanks,

Brian
_______________________________________________
gtk-perl-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-perl-list