Patch: Install complete sources of TestGTK.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch: Install complete sources of TestGTK.

Björn Persson-3
"make install" doesn't install the complete source code of TestGTK. The
subdirectory opengl and the file refresh.svg are missing. Main_Windows
requires View_GL even when OpenGL support is disabled.

Here's a patch to install the missing source files. It's meant to be
applied after the "directories" patch.

Björn Persson

_______________________________________________
gtkada mailing list
[hidden email]
http://lists.adacore.com/mailman/listinfo/gtkada

0001-Install-complete-sources-of-TestGTK.patch (949 bytes) Download Attachment
attachment1 (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch: Install complete sources of TestGTK.

Emmanuel Briot
> "make install" doesn't install the complete source code of TestGTK. The
> subdirectory opengl and the file refresh.svg are missing. Main_Windows
> requires View_GL even when OpenGL support is disabled.

Bjorn,

I think this patch is wrong.
You are systematically installing the opengl testgtk sources, even when opengl is
not supported or wasn't compiled.
Instead, the default Makefile will install these sources if they are parse of the testgtk.gpr
project, i.e. if OpenGL is indeed supported.

Installing the svg file makes sense though, so I have modified Makefile.in accordingly.

As Nicolas mentioned, please use github to submit patches though, so that we can more easily
comment and merge those patches...

Thanks
Emmanuel
_______________________________________________
gtkada mailing list
[hidden email]
http://lists.adacore.com/mailman/listinfo/gtkada
Reply | Threaded
Open this post in threaded view
|

Re: Patch: Install complete sources of TestGTK.

Björn Persson-3
Emmanuel Briot wrote:

> > "make install" doesn't install the complete source code of TestGTK.
> > The subdirectory opengl and the file refresh.svg are missing.
> > Main_Windows requires View_GL even when OpenGL support is
> > disabled.  
>
> Bjorn,
>
> I think this patch is wrong.
> You are systematically installing the opengl testgtk sources, even
> when opengl is not supported or wasn't compiled.
> Instead, the default Makefile will install these sources if they are
> parse of the testgtk.gpr project, i.e. if OpenGL is indeed supported.
It hasn't done that for me so far. Perhaps I'll try again with GPRbuild
2016 when I'm done upgrading that.

> As Nicolas mentioned, please use github to submit patches though, so
> that we can more easily comment and merge those patches...

Yeah, I didn't yet get around to making a fork on Github, rebasing my
copy to that fork, and so on.

Björn Persson

_______________________________________________
gtkada mailing list
[hidden email]
http://lists.adacore.com/mailman/listinfo/gtkada

attachment0 (836 bytes) Download Attachment