Since quite some time (as also discussed on the list previously (Midi Import Broken)
I've been seeing these messages during midi import: (beast-0.10.1:32358): BSE-WARNING **: item "BseSong::export.mid" has no property named `bpm' (beast-0.10.1:32358): BSE-WARNING **: no such method "ensure-master-bus" of item "BseSong::export.mid" and import ended up being incomplete. Here is a fix for that. Stefan Westerfeld (1): BSE: fix midi import problems related to Bse::Song API updates bse/bsemidifile.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.7.4 _______________________________________________ beast mailing list [hidden email] https://mail.gnome.org/mailman/listinfo/beast |
Signed-off-by: Stefan Westerfeld <[hidden email]>
--- bse/bsemidifile.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bse/bsemidifile.cc b/bse/bsemidifile.cc index 6cb3c59..f0693ed 100644 --- a/bse/bsemidifile.cc +++ b/bse/bsemidifile.cc @@ -315,16 +315,15 @@ void bse_midi_file_setup_song (BseMidiFile *smf, BseSong *bsong) { - BseBus *master_bus; uint i, j; bse_item_set_undoable (bsong, "tpqn", smf->tpqn, "numerator", smf->numerator, "denominator", smf->denominator, - "bpm", smf->bpm, NULL); - bse_item_exec (bsong, "ensure-master-bus", &master_bus); Bse::SongImpl &song = *bsong->as<Bse::SongImpl*>(); + song.bpm (smf->bpm); + song.ensure_master_bus(); for (i = 0; i < smf->n_tracks; i++) { BseMidiFileTrack *track = smf->tracks + i; -- 2.7.4 _______________________________________________ beast mailing list [hidden email] https://mail.gnome.org/mailman/listinfo/beast |
Thanks for this and a bunch of other patches Stefan.
It's all pushed now, keep it up! On 11.03.2017 18:48, Stefan Westerfeld wrote: > Signed-off-by: Stefan Westerfeld <[hidden email]> > --- > bse/bsemidifile.cc | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/bse/bsemidifile.cc b/bse/bsemidifile.cc > index 6cb3c59..f0693ed 100644 > --- a/bse/bsemidifile.cc > +++ b/bse/bsemidifile.cc > @@ -315,16 +315,15 @@ void > bse_midi_file_setup_song (BseMidiFile *smf, > BseSong *bsong) > { > - BseBus *master_bus; > uint i, j; > bse_item_set_undoable (bsong, > "tpqn", smf->tpqn, > "numerator", smf->numerator, > "denominator", smf->denominator, > - "bpm", smf->bpm, > NULL); > - bse_item_exec (bsong, "ensure-master-bus", &master_bus); > Bse::SongImpl &song = *bsong->as<Bse::SongImpl*>(); > + song.bpm (smf->bpm); > + song.ensure_master_bus(); > for (i = 0; i < smf->n_tracks; i++) > { > BseMidiFileTrack *track = smf->tracks + i; > -- Yours sincerely, Tim Janik https://testbit.eu/timj/ Free software author. _______________________________________________ beast mailing list [hidden email] https://mail.gnome.org/mailman/listinfo/beast |
Free forum by Nabble | Edit this page |