Do I need to #define GLIB_CHARSETALIAS_DIR ?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Do I need to #define GLIB_CHARSETALIAS_DIR ?

John Emmas-2
I'm building glib (from git master) using MSVC (using my own VC
projects). This morning I noticed a change at line 68 in
'glib/libcharset/localcharset.c'

Previous code:-
       /* Get LIBDIR.  */
       #ifndef LIBDIR
       # include "configmake.h"
       #endif

New code:-
       /* Get GLIB_CHARSETALIAS_DIR.  */
       #ifndef GLIB_CHARSETALIAS_DIR
       # include "configmake.h"
       # define GLIB_CHARSETALIAS_DIR LIBDIR
       #endif

My MSVC build is now failing because 'configmake.h' doesn't exist on my
system.  Do I need to get it from somewhere?  Or do I need to #define
GLIB_CHARSETALIAS_DIR to something?  Thanks,

John
(P.S. I'm not using 'make' BTW).
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Reply | Threaded
Open this post in threaded view
|

Re: Do I need to #define GLIB_CHARSETALIAS_DIR ?

Nirbheek Chauhan
On Sun, Dec 3, 2017 at 8:47 PM, John Emmas <[hidden email]> wrote:
> I'm building glib (from git master) using MSVC (using my own VC projects).
> This morning I noticed a change at line 68 in
> 'glib/libcharset/localcharset.c'
>

I believe that was an unnecessary regression, can you please try the
latest patch I've attached to the relevant bug:

https://bugzilla.gnome.org/show_bug.cgi?id=346816#c18

Cheers,
Nirbheek
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Reply | Threaded
Open this post in threaded view
|

Re: Do I need to #define GLIB_CHARSETALIAS_DIR ?

John Emmas-2
On 03/12/2017 15:38, Nirbheek Chauhan wrote:
> can you please try the latest patch I've attached to the relevant bug:
>
> https://bugzilla.gnome.org/show_bug.cgi?id=346816#c18
>
> Cheers,
> Nirbheek
>

Thanks for the quick reply, Nirbkeek.  If you mean this patch:-

https://bugzilla.gnome.org/attachment.cgi?id=364856&action=diff

I'm pretty sure it'll work (as that's exactly what I did myself !)

John
_______________________________________________
gtk-devel-list mailing list
[hidden email]
https://mail.gnome.org/mailman/listinfo/gtk-devel-list